Skip to content

Conversation

@cmarmo
Copy link
Member

@cmarmo cmarmo commented May 24, 2024

This pull request removes doubled paragraphs in the presubmission issue template.
Thanks for considering it.

Copy link
Collaborator

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; agreeing that these were mostly redundant, but see comments on restructuring this further.

Copy link
Collaborator

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one tiny change left that could be taken care of here: there's a missing space after the Astropy: entry.

@cmarmo
Copy link
Member Author

cmarmo commented May 26, 2024

there's a missing space after the Astropy: entry.

Indeed! Done. :)

@lwasser
Copy link
Member

lwasser commented May 29, 2024

@cmarmo @cmarmo THANK YOU for this pr! in the future once you have one "approval" from the editorial team, please do feel free to merge. The only exception might be if it is a significant change to our review process - then we'd want a few more team members to review / discuss if needed! 👐🏻

@lwasser lwasser merged commit c8e4e45 into pyOpenSci:main May 29, 2024
@lwasser
Copy link
Member

lwasser commented May 29, 2024

@all-contributors please add @dhomeier for code, review

@allcontributors
Copy link
Contributor

@lwasser

I've put up a pull request to add @dhomeier! 🎉

@cmarmo cmarmo deleted the patch-presubmission branch May 29, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants