Skip to content

Visualization of Sieve of Eratosthenes algorithm #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 2, 2020
Merged

Visualization of Sieve of Eratosthenes algorithm #181

merged 3 commits into from
Jan 2, 2020

Conversation

@hs2361
Copy link
Contributor

@hs2361 hs2361 commented Dec 22, 2019

This is to address issue #180
This is a visualization of the Sieve of Eratosthenes algorithm for finding prime numbers below any natural number 'n'.
@pep8speaks
Copy link

pep8speaks commented Dec 22, 2019 •
edited
Loading

Hello @hs2361! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 139:31: E114 indentation is not a multiple of four (comment)
Line 139:31: E117 over-indented (comment)

Comment last updated at 2019-12-29 07:46:05 UTC
prateekiiest
prateekiiest requested changes Dec 28, 2019
View reviewed changes
Copy link
Owner

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show me your code output
hs2361
hs2361 commented Dec 29, 2019
View reviewed changes
Copy link
Contributor Author

@hs2361 hs2361 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make the necessary changes, and re-submit this PR
@prateekiiest
Copy link
Owner

prateekiiest commented Dec 29, 2019

make the changes in this PR only, by pushing more commits here
hs2361
hs2361 commented Dec 29, 2019
View reviewed changes
Copy link
Contributor Author

@hs2361 hs2361 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the necessary changes
@prateekiiest
Copy link
Owner

prateekiiest commented Dec 29, 2019

Please post an output of the code here
@hs2361
Copy link
Contributor Author

hs2361 commented Jan 2, 2020

  1. image

  2. The program actually produces an animation of highlighting all the cells, but here I am only uploading a screenshot.
    image

  3. image
@prateekiiest
Copy link
Owner

prateekiiest commented Jan 2, 2020

Looks good!
Thanks for the contribution @hs2361 🎉 🎉 .
Feel free to add yourself under the contributor list
@prateekiiest prateekiiest merged commit 28ade47 into prateekiiest:master Jan 2, 2020
@prateekiiest prateekiiest mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@hs2361 @pep8speaks @prateekiiest