updated tts to enable the user to enter text #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| from gtts import gTTS | ||
| | ||
| text = ("Hello world!") | ||
| text = input("Enter the text you want to convert: ") |
Owner
There was a problem hiding this comment.
I guess this might break the functionality.
Have you tested this?
Also it would be good if you can write a test case for this
Contributor Author
There was a problem hiding this comment.
I don't actually understand how it breaks functionality. When I tested, it was able to convert the text I entered to an audio file, which is what it is supposed to do. Am I missing something here?
Owner
There was a problem hiding this comment.
In some cases, input(text) does not always work, depending on the version. I have tested it locally in this case. And it works fine.
prateekiiest approved these changes Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution. Please provide the details requested below.
ISSUE NUMBER
NIL
SHORT DESCRIPTION
The user can enter their own text to convert to speech without altering the code.
TESTING
NIL