tests: remove duplicated file with wrong name casing #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

hrach wants to merge 1 commit into phpstan:master from hrach:rm_duplicates

Contributor

hrach commented Jan 4, 2020

There is also (duplicated) bug2574.php

tests: remove duplicated file with wrong name casing

76e8283

Member

ondrejmirtes commented Jan 4, 2020 •

edited

Loading

Hi, we can't remove it like this, the build will start failing on case-insensitive filesystems: https://travis-ci.org/phpstan/phpstan-src/jobs/632627352#L271-L275

Do you have any suggestions how to do it right?

Contributor Author

hrach commented Jan 4, 2020

Sorry, I don't understand, how GenericsIntegrationTest::testLevels works with Bug2574.php? The bug2574.php should be still in repo. (https://github.com/phpstan/phpstan-src/blob/76e8283e4bce9299abc7e4d8ab738b5850721043/tests/PHPStan/Generics/data/bug2574.php vs https://github.com/phpstan/phpstan-src/blob/76e8283e4bce9299abc7e4d8ab738b5850721043/tests/PHPStan/Generics/data/Bug2574.php)

Member

ondrejmirtes commented Jan 4, 2020

It looks like Git removes both files when this branch is checked out on macOS or Windows.

Member

ondrejmirtes commented Jan 19, 2020

Please open the PR again if you figure this out. Thank you.

ondrejmirtes closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment