Fix unit-test cross-OS glitches #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
staabm commented Nov 10, 2019
| * @param string $actual | ||
| * @param string $message | ||
| */ | ||
| protected function assertSamePaths(string $expected, string $actual, string $message = ''): void |
There was a problem hiding this comment.
I put his helper in the base-class because I guess it can be re-used to fix a few of the remaining 6 windows-only testsuite errors
There was a problem hiding this comment.
I agree with that, but try using FileHelper instead of str_replace.
There was a problem hiding this comment.
If it doesn't succeed, I'm gonna merge this as it is.
There was a problem hiding this comment.
using normalizePath will make the test error on windows travis CI
ondrejmirtes requested changes Nov 10, 2019
src/Testing/TestCase.php Outdated
| protected function assertSamePaths(string $expected, string $actual, string $message = ''): void | ||
| { | ||
| $expected = str_replace('/', DIRECTORY_SEPARATOR, $expected); | ||
| $actual = str_replace('/', DIRECTORY_SEPARATOR, $actual); |
There was a problem hiding this comment.
Try $this->getFileHelper()->normalizePath() for the same result. Otherwise good idea!
| Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes 2 of the 8 windows-only testfailures mentioned in #5 (comment)