Skip to content

Implement ArrayAccess in ext-ds #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Implement ArrayAccess in ext-ds #723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions stubs/ext-ds.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Ds;

use ArrayAccess;
use Countable;
use JsonSerializable;
use OutOfBoundsException;
Expand Down Expand Up @@ -92,8 +93,9 @@ final class Deque implements Sequence
* @template TKey
* @template TValue
* @implements Collection<TKey, TValue>
* @implements ArrayAccess<TKey, TValue>
*/
final class Map implements Collection
final class Map implements Collection, ArrayAccess
{
/**
* @param iterable<TKey, TValue> $values
Expand Down Expand Up @@ -380,8 +382,9 @@ final class Pair implements JsonSerializable
/**
* @template TValue
* @extends Collection<int, TValue>
* @extends ArrayAccess<int, TValue>
*/
interface Sequence extends Collection
interface Sequence extends Collection, ArrayAccess
{
/**
* @param callable(TValue): TValue $callback
Expand Down Expand Up @@ -597,8 +600,9 @@ final class Vector implements Sequence
/**
* @template TValue
* @implements Collection<int, TValue>
* @implements ArrayAccess<int, TValue>
*/
final class Set implements Collection
final class Set implements Collection, ArrayAccess
{
/**
* @param iterable<TValue> $values
Expand Down Expand Up @@ -752,8 +756,9 @@ final class Set implements Collection
/**
* @template TValue
* @implements Collection<int, TValue>
* @implements ArrayAccess<int, TValue>
*/
final class Stack implements Collection
final class Stack implements Collection, ArrayAccess
{
/**
* @param iterable<TValue> $values
Expand Down Expand Up @@ -804,8 +809,9 @@ final class Stack implements Collection
/**
* @template TValue
* @implements Collection<int, TValue>
* @implements ArrayAccess<int, TValue>
*/
final class Queue implements Collection
final class Queue implements Collection, ArrayAccess
{
/**
* @param iterable<TValue> $values
Expand Down