add JUnit error formatter #65
Conversation
| Thank you 😊 I think it would be best to rewrite the code in style of the checkstyle formatter 😊 |
| @ondrejmirtes should be fixed, let me know if it's fine to have ext-dom in dev env. |
| "phpstan/phpstan": "self.version" | ||
| }, | ||
| "require-dev": { | ||
| "ext-dom": "*", |
There was a problem hiding this comment.
AFAIK this should not be added.
There was a problem hiding this comment.
What do you need it for in dev?
There was a problem hiding this comment.
@ondrejmirtes It's useful to do XML validation, see https://github.com/phpstan/phpstan-src/pull/65/files#diff-ba74c4a649ddce093d63acd494b761d6R157 but we can remove this assertion if you think is not useful
| @ondrejmirtes do you mean |
| I haven't realized it's a separate README :) Feel free to send a PR there after this is merged :) After you fix the build this is good to merge :) |
mavimo force-pushed the feature/add-junit-error-formatter branch from 43ce4d0 to da39079 Compare 
| Thank you, perfect! :) Will be released in 0.12.4 after the holidays. |
| @ondrejmirtes nice! I'll update the README ASAP (and close my repo once the formatter will be released in phpstan :) ) |
2 participants
SSIA
@ondrejmirtes the CI fail since we are going to use and extension that is not required in the composer.json, we have three options:
Include ext-dom as dependencyIgnoring the errorLet me know what's your favourite solution :)