Range with strings #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ondrejmirtes requested changes Dec 22, 2019
| if ($startType instanceof StringType | ||
| && $endType instanceof StringType | ||
| && $stepType instanceof IntegerType) { | ||
| return new ArrayType(new IntegerType(), new StringType()); |
There was a problem hiding this comment.
Hi, I'd like the suggested logic from phpstan/phpstan#2378 (comment). These if statements won't cover all cases.
| use PHPStan\Type\StringType; | ||
| use PHPUnit\Framework\MockObject\MockObject; | ||
| | ||
| class RangeFunctionReturnTypeExtensionTest extends \PHPStan\Testing\TestCase |
There was a problem hiding this comment.
Hi, this isn't at all how dynamic return type extensions are tested. Please add new dataProvider to NodeScopeResolverTest::testFileAsserts and test it there. THank you.
| Please open the PR again if you decide to finish it. Thanks. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#2378