Fixed signatures of gmp_div, odbc_exec and unregister_tick_function #533
Conversation
resources/functionMap.php Outdated
| 'odbc_error' => ['string', 'connection_id='=>'resource'], | ||
| 'odbc_errormsg' => ['string', 'connection_id='=>'resource'], | ||
| 'odbc_exec' => ['resource', 'connection_id'=>'resource', 'query'=>'string', 'flags='=>'int'], | ||
| 'odbc_exec' => ['resource|false', 'connection_id'=>'resource', 'query'=>'string', 'flags='=>'int'], // Note: 'flags' was removed in PHP 8.0 |
There was a problem hiding this comment.
The note is useless here, you can submit a change to https://github.com/phpstan/phpstan-src/blob/master/resources/functionMap_php80delta.php instead
There was a problem hiding this comment.
Okay. Will you do it, or do I need to send a new pull request?
There was a problem hiding this comment.
Modify this PR so it can be merged, thanks.
There was a problem hiding this comment.
Ok, I changed the PR
resources/functionMap.php Outdated
| 'unlink' => ['bool', 'filename'=>'string', 'context='=>'resource'], | ||
| 'unpack' => ['array|false', 'format'=>'string', 'data'=>'string', 'offset='=>'int'], | ||
| 'unregister_tick_function' => ['void', 'function_name'=>'string'], | ||
| 'unregister_tick_function' => ['void', 'callback'=>'callable'], |
There was a problem hiding this comment.
The parameter does not need to be renamed
There was a problem hiding this comment.
Okay, sounds good. I just looked in the old manual . In PHP 7, it was called "$function_name" , and in PHP 8 it was renamed to "$callback" (so it should be renamed in functionMap_php80delta.php then)
There was a problem hiding this comment.
This doesn't need to be done, the PHP 8 signatures are mostly taken from https://github.com/phpstan/php-8-stubs/blob/main/stubs/ext/standard/unregister_tick_function.php already.
| Thank you! |
2 participants
gmp_div: Return type is GMP , not resource
odbc_exec: Return type is resource|false , not resource
Note that the "flags" argument will be removed in PHP 8.0
unregister_tick_function: argument is now called "callback" and type "callable" instead of "string"
Example: $callable=array(&$object, 'my_method') or $callable=array('Object', 'my_method')