Improve EnumSanityRule #4543
Open
Improve EnumSanityRule #4543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
VincentLanglet commented Nov 10, 2025
| } | ||
| if ($enumNode->scalarType === null && $stmt->expr !== null) { | ||
| $errors[] = RuleErrorBuilder::message(sprintf( | ||
| 'Enum %s is not backed, but case %s has value.', |
Contributor Author
There was a problem hiding this comment.
The message changed from
Enum %s is not backed, but case %s has value %s. to
Enum %s is not backed, but case %s has value. I'm not sure you're okay with this or if
- it should be behind bleedingEdge
- it should be behind some extra condition (and have two differents messages ?)
src/Rules/Classes/EnumSanityRule.php Outdated
| | ||
| $exprType = $scope->getType($stmt->expr); | ||
| $constantValues = $exprType->getConstantScalarValues(); | ||
| if (count($constantValues) === 1) { |
Contributor Author
There was a problem hiding this comment.
By setting enum cases value here, instead of in the condition
if ($stmt->expr instanceof Node\Scalar\Int_ || $stmt->expr instanceof Node\Scalar\String_) I also catch other constant values like the one set with a class Constant.
Cf test
enum Backed: int { case One = Foo::A; case Two = Foo::A; } 
VincentLanglet force-pushed the enumSanity branch from d605da6 to 22ab2d1 Compare 
VincentLanglet force-pushed the enumSanity branch from 22ab2d1 to 37b0e41 Compare 
staabm reviewed Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13768