Skip to content

Fix UnionType::getObjectClassReflections #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.1.x
Choose a base branch
from
+18 −14
Open

Fix UnionType::getObjectClassReflections #4541

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff2ba1
Access Union::getObjectClassReflections
VincentLanglet Nov 9, 2025
52264b1
Rework
VincentLanglet Nov 9, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Access Union::getObjectClassReflections
  • Loading branch information
@VincentLanglet
VincentLanglet committed Nov 9, 2025
commit 9ff2ba18232da649a5a3d2bd8d526eb5e4b3345e
13 changes: 12 additions & 1 deletion src/Rules/PhpDoc/RequireExtendsCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use PHPStan\Rules\ClassNameUsageLocation;
use PHPStan\Rules\IdentifierRuleError;
use PHPStan\Rules\RuleErrorBuilder;
use PHPStan\Type\UnionType;
use PHPStan\Type\VerbosityLevel;
use function array_column;
use function array_map;
Expand Down Expand Up @@ -59,8 +60,18 @@ public function checkExtendsTags(Scope $scope, Node $node, array $extendsTags):
continue;
}

if ($type instanceof UnionType) {
$classReflections = [];
foreach ($type->getTypes() as $subType) {
$classReflections[] = $subType->getObjectClassReflections();
}
$classReflections = array_merge(...$classReflections);
} else {
$classReflections = $type->getObjectClassReflections();
}

sort($classNames);
$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $type->getObjectClassReflections());
$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $classReflections);
$referencedClassReflectionsMap = array_column($referencedClassReflections, 0, 1);
foreach ($classNames as $class) {
$referencedClassReflection = $referencedClassReflectionsMap[$class] ?? null;
Expand Down
13 changes: 12 additions & 1 deletion src/Rules/PhpDoc/RequireImplementsDefinitionTraitRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use PHPStan\Rules\ClassNameUsageLocation;
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleErrorBuilder;
use PHPStan\Type\UnionType;
use PHPStan\Type\VerbosityLevel;
use function array_column;
use function array_map;
Expand Down Expand Up @@ -66,7 +67,17 @@ public function processNode(Node $node, Scope $scope): array
continue;
}

$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $type->getObjectClassReflections());
if ($type instanceof UnionType) {
$classReflections = [];
foreach ($type->getTypes() as $subType) {
$classReflections[] = $subType->getObjectClassReflections();
}
$classReflections = array_merge(...$classReflections);
} else {
$classReflections = $type->getObjectClassReflections();
}

$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $classReflections);
$referencedClassReflectionsMap = array_column($referencedClassReflections, 0, 1);
foreach ($classNames as $class) {
$referencedClassReflection = $referencedClassReflectionsMap[$class] ?? null;
Expand Down
13 changes: 12 additions & 1 deletion src/Rules/PhpDoc/SealedDefinitionClassRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use PHPStan\Rules\ClassNameUsageLocation;
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleErrorBuilder;
use PHPStan\Type\UnionType;
use PHPStan\Type\VerbosityLevel;
use function array_column;
use function array_map;
Expand Down Expand Up @@ -69,7 +70,17 @@ public function processNode(Node $node, Scope $scope): array
continue;
}

$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $type->getObjectClassReflections());
if ($type instanceof UnionType) {
$classReflections = [];
foreach ($type->getTypes() as $subType) {
$classReflections[] = $subType->getObjectClassReflections();
}
$classReflections = array_merge(...$classReflections);
} else {
$classReflections = $type->getObjectClassReflections();
}

$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $classReflections);
$referencedClassReflectionsMap = array_column($referencedClassReflections, 0, 1);
foreach ($classNames as $class) {
$referencedClassReflection = $referencedClassReflectionsMap[$class] ?? null;
Expand Down
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/PhpDoc/SealedDefinitionClassRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ public function testRule(): void
26,
'Learn more at https://phpstan.org/user-guide/discovering-symbols',
],
[
'PHPDoc tag @phpstan-sealed contains unknown class IncompatibleSealed\UnknownClass.',
46,
'Learn more at https://phpstan.org/user-guide/discovering-symbols',
],
]);
}

Expand Down
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/PhpDoc/data/incompatible-sealed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,8 @@ interface ValidInterface {}
* @phpstan-sealed SomeInterface
*/
interface ValidInterface2 {}

/**
* @phpstan-sealed UnknownClass|SomeClass
*/
class InvalidClassWithUnion {}