Improve return type of base64_decode() #4492
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Detect when the result cannot be false - Correctly treat non-boolean $strict parameter
| | ||
| return new StringType(); | ||
| if ($isStrict->maybe() && $isValidBase64->maybe()) { | ||
| return new BenevolentUnionType([new StringType(), new ConstantBooleanType(false)]); |
There was a problem hiding this comment.
Why a benevolent one ? I think it should be a simple union
There was a problem hiding this comment.
I figured if the strictness is unclear (which almost never happens), then a benevolent union is better (based on the previous behavior). But of course this can be changed.
There was a problem hiding this comment.
Oh, didn't know it was the previous behavior.
Indeed https://phpstan.org/r/54560d00-fc90-4e4f-bc72-74a670a8e415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix handling of non-bools as
$strictparameter and omitfalsefrom return type when$stringis valid base64.This is useful when constant binary strings are required in code, e.g.:
Related to phpstan/phpstan#7866