Fix DOMElement::getAttributeNode and DOMElement::getAttributeNodeNS #4484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While looking at #3714
I discovered that getAttributeNode/getAttributeNodeNS return type was wrong
cf https://www.php.net/manual/en/domelement.getattributenode.php
and https://www.php.net/manual/en/domelement.getattributenodens.php
I fixed it in JetBrains/phpstorm-stubs#1811
but then we will end with false positive since PHPStan does not understand
hasAttribute,so I added a benevolent union.
I also added the non-regression from #3714 to show the related-issues are solved
Closes #3714