array_key_exist inference is lost when adding a false condition #4473
Conversation
staabm force-pushed the types-lost-in-never-cond branch from fb48fb4 to d93abb5 Compare 
| This pull request has been marked as ready for review. |
staabm force-pushed the types-lost-in-never-cond branch from 4b2b7a5 to 821db45 Compare 
| So no issue with this PR ? Thanks for finding it ! |
| I think it works (but did not re-use your previous implementation) |
staabm force-pushed the types-lost-in-never-cond branch 2 times, most recently from 6b9f420 to 0844b34 Compare staabm force-pushed the types-lost-in-never-cond branch from 0844b34 to d02bcc3 Compare 
src/Analyser/TypeSpecifier.php Outdated
| | ||
| if ($context->true()) { | ||
| if ( | ||
| $scope->getType($expr->left)->isFalse()->yes() |
There was a problem hiding this comment.
My head hurts 😅
I think all the isTrue/isFalse calls should do toBoolean() beforehand.
There was a problem hiding this comment.
great catch. fixed.
thank you.
There was a problem hiding this comment.
hmm maybe we should have a $type->isFalse()->yes()/$type->isTrue()->yes() to $type->toBoolean()->isFalse()->yes()/$type->toBoolean()->isTrue()->yes() mutator.
it would make us aware of false/falsey coverage
.github/workflows/tests.yml Outdated
| run: | | ||
| php build-infection/bin/infection-config.php \ | ||
| --source-directory='build/PHPStan/Build' \ | ||
| --timeout=180 \ |
There was a problem hiding this comment.
in the worst case infection needs enough time to run the full test-suite.
otherwise mutants are considered 'skipped', which we saw in CI:
this setting means: "how many seconds can infection spent on a single mutant"
There was a problem hiding this comment.
opened a new ticket, as we need more information to proceed.
infection/infection#2510
even after raising the timeout to 300 it still times out.
so at phpstan-src repo we are so slow, that we can't even check 3 mutants in 15minutes CI runtime.
we can merge for now
There was a problem hiding this comment.
lets fix this in a separate PR
| Make a build-infection issue for the new mutator idea 😊 |
| Thank you! |
4 participants
closes phpstan/phpstan#11276
fixes phpstan/phpstan-phpunit#100