Skip to content

Introduce __stringnotstringable #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from
Open

Introduce __stringnotstringable #4457

wants to merge 1 commit into from

Conversation

@VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Oct 19, 2025

Naming to debate ? __stringwithoutstringable ?

intval($stringable) is never allowed, even without strict_types.

The current check in FunctionCallParameterCheck is

$this->ruleLevelHelper->accepts($parameterType, $argumentValueType, $scope->isDeclareStrictTypes());

either we're doing something like

$this->ruleLevelHelper->accepts( $parameterType, $argumentValueType, $scope->isDeclareStrictTypes() || in_array($functionName, ['floatval', 'intval', 'doubleval'], true) );

either we have to introduce the opposite of StringAlwaysAcceptingObjectWithToStringType like I did.

Closes phpstan/phpstan#6560
Closes #1005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@VincentLanglet