Skip to content

Fix too wide bool in trivial methods #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: 2.1.x
Choose a base branch
from
Open

Fix too wide bool in trivial methods #4444

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eaabab0
Fix too wide bool in trivial methods
staabm Oct 16, 2025
b67d699
ignore also bool phpdoc
staabm Oct 16, 2025
3f693c3
for literal return true and return false, not for return $this->foo->…
staabm Oct 16, 2025
dff8bcb
fix php < 8.2
staabm Oct 16, 2025
2741649
simplify
staabm Oct 16, 2025
8e62371
cs
staabm Oct 16, 2025
45a2a5b
fix
staabm Oct 16, 2025
cc45c51
Discard changes to tests/PHPStan/Rules/TooWideTypehints/TooWideFuncti…
staabm Oct 17, 2025
488c4d5
Discard changes to tests/PHPStan/Rules/TooWideTypehints/TooWideMethod…
staabm Oct 17, 2025
07029d8
adjust tests
staabm Oct 17, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@staabm
staabm committed Oct 29, 2025
commit 45a2a5be607aafb8bc12d74a3f9a2252e4afddab
11 changes: 1 addition & 10 deletions tests/PHPStan/Rules/TooWideTypehints/TooWideMethodReturnTypehintRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,16 +238,7 @@ public function testBug13384cPrePhp82(): void
{
$this->reportTooWideBool = true;
$this->reportNestedTooWideType = true;
$this->analyse([__DIR__ . '/data/bug-13384c.php'], [
[
'Method Bug13384c\Bug13384c::doBarPhpdoc() never returns false so the return type can be changed to true.',
55,
],
[
'Method Bug13384c\Bug13384Static::doBarPhpdoc() never returns false so the return type can be changed to true.',
84,
],
]);
$this->analyse([__DIR__ . '/data/bug-13384c.php'], []);
}

public function testBug13384cOff(): void
Expand Down