Support union types in curl_setopt validation #4396
Merged
+58 −26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This pull request has been marked as ready for review. |
ondrejmirtes requested changes Oct 1, 2025
| continue; | ||
| } | ||
| | ||
| $optValueType = TypeCombinator::union($optValueType, $valueType); |
There was a problem hiding this comment.
It'd be more performant to call ::union just once once we gather all the types to union.
| Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
while working on #4395 I realized there is a low hanging fruit by getting rid of
instanceof ConstantIntegerType