Added regression tests #4393
Merged
Added regression tests #4393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @ondrejmirtes the nsrt tests reveal some interessting (I did not yet make sure the assert-types are super accurate, but as soon as I noticed we see some see e.g. nsrt/bug-10640.php |
| ok, scratch the above comment. I somehow mixed it up. should be good to go now. |
| This pull request has been marked as ready for review. |
| Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
covers fixes we see in https://github.com/phpstan/phpstan-src/actions/runs/18133279748
closes phpstan/phpstan#6173
closes phpstan/phpstan#10640
closes phpstan/phpstan#10025
closes phpstan/phpstan#12078