Add Insane Comparison Rule #423
Conversation
| - | ||
| class: PHPStan\Rules\Comparison\InsaneComparisonRule | ||
| arguments: | ||
| treatMixedAsPossibleString: %reportMaybes% |
There was a problem hiding this comment.
I'm not sure whether this should be switchable, I'd prefer always enabling it
| // if ($left_type instanceof ErrorType || $right_type instanceof ErrorType) { | ||
| // return []; | ||
| // } |
There was a problem hiding this comment.
Should I uncomment this?
tests/PHPStan/Rules/Comparison/data/insane-comparison-maybe.php Outdated Show resolved Hide resolved
| Hi @ondrejmirtes. Could you please take a look at this? |
| Hi, this code will need some work but I'm currently busy to look into this. Stay tuned! |
| Hi @ondrejmirtes. I'd like to finish the thing and have it merged. Any chance having this reviewed? |
| Hi, it'd need some more work to be able to merge this. For example I don't want the new RuleLevelHelper would also make sure that some errors are reported on level 5 while others (when partially wrong unions are involved) are reported on level 7. Additionally, the error message needs improvement by saying what's wrong about the comparison. |
ondrejmirtes force-pushed the master branch 2 times, most recently from efd31ce to 0471f87 Compare ondrejmirtes force-pushed the 1.5.x branch 3 times, most recently from ddd20b4 to 95d480b Compare | Hi, I'm cleaning up old and stale PRs. Please send a new PR if you're still interested, thanks. |
| Hi @ondrejmirtes! I don't plan to reimplement this. This rule was about https://wiki.php.net/rfc/string_to_number_comparison – breaking change in PHP 8. I think this is a good feature, but it's hard to implement it. Personally, I think it's easier to just create a rule |
2 participants
This is a follow up for phpstan/phpstan#4359