Support @psalm-pure and @phpstan-pure annotations #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ondrejmirtes requested changes Dec 27, 2020
Member
ondrejmirtes left a comment
ondrejmirtes left a comment There was a problem hiding this comment.
Thank you, I appreciate this. Although there's much more work that needs to be done, I don't want to be exactly 1:1 with Psalm as this area is very complicated. I consider "pure" functions to consist of two attributes - hasSideEffects, and isDeterministic. We can find examples of functions and methods in all 4 brackets - yes/yes, yes/no, no/yes, no/no. And they behave differently and different situations, which will influence the analysis.
tests/PHPStan/Rules/Methods/data/static-method-call-statement-no-side-effects-phpdoc.php Outdated Show resolved Hide resolved
tests/PHPStan/Rules/Methods/data/method-call-statement-no-side-effects-phpdoc.php Outdated Show resolved Hide resolved
tests/PHPStan/Rules/Functions/data/function-call-statement-no-side-effects-phpdoc.php Outdated Show resolved Hide resolved
Contributor Author
| @ondrejmirtes done |
Member
| Added a commit with backwards compatibility and also the ability to set "impure" functions: c99316d |
Member
| @b1rdex Thank you! |
This was referenced Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
CallToFunctionStamentWithoutSideEffectsRuleTestdoesn't find errors and I don't know how to fix it. Running analysis withbin/phpstanfinds them correctly.@purefunctions/methods for purity. I think this might be postponed for now and solved in the future.