Skip to content

Fix offset existence check on ArrayAccess intersections #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix offset existence check on ArrayAccess intersections #363

wants to merge 1 commit into from

Conversation

@b1rdex
Copy link
Contributor

@b1rdex b1rdex commented Oct 28, 2020

Closes phpstan/phpstan#3836

I'm not sure whether it's a correct way or not...
@b1rdex
Fix offset existence check on ArrayAccess intersections
1a0c975 
Closes phpstan/phpstan#3836 I'm not sure whether it's a correct way or not...
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Oct 28, 2020

Nope, this is the wrong solution. The right solution is to modify ObjectType and have hasOffsetValueType return at least maybe: if it's representing an interface or a non-final class.
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Oct 28, 2020

Best way is to modify ObjectType::isExtraOffsetAccessibleClass().
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Oct 28, 2020

Done: b55656f

Thanks for the test :)
@b1rdex b1rdex deleted the bug-3836 branch October 29, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@b1rdex @ondrejmirtes