setlocale() can take as argument 0 and NULL

[peter-gribanov]

https://www.php.net/manual/en/function.setlocale.php

If locale is NULL or the empty string "", the locale names will be set from the values of environment variables with the same names as the above categories, or from "LANG".
If locale is "0", the locale setting is not affected, only the current setting is returned.

[ondrejmirtes]

Is it supposed to be integer 0 or string "0"?

[peter-gribanov]

Is a integer, not a string.

[peter-gribanov]

No, though. Wait. It seems i'm wrong.

[peter-gribanov]

It is not obvious to me from the documentation which data type should be used. Integer is most commonly used. It's not obvious to me in the source either. Both options work the same way.

[ondrejmirtes]

Yeah, these functions are weird, the documentation talks about string only though. I'd accept a PR that changes the type to string|null.

[peter-gribanov]

@ondrejmirtes please review

[ondrejmirtes]

Thank you!