Issue #3964: Add ArraySumFunctionDynamicReturnTypeExtension for array_sum function #350
Conversation
Signed-off-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
Signed-off-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
Signed-off-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
| if ($keyType instanceof UnionType) { | ||
| $floatType = new FloatType(); | ||
| | ||
| if ($keyType->accepts($floatType, true)->yes()) { |
There was a problem hiding this comment.
The basic logic that accounts for most use-cases automatically should be as followed:
$isInteger = (new IntegerType())->isSuperTypeOf($argType); $isFloat = (new FloatType())->isSuperTypeOf($argType); $comparison = $isInteger->compareTo($isFloat); if ($comparison === $isInteger) { return new IntegerType(); } elseif ($comparison === $isFloat) { return new FloatType(); } return new UnionType([new IntegerType(), new FloatType()]);There was a problem hiding this comment.
$comparison is always null if I try this snippet.
There was a problem hiding this comment.
That shouldn't be the case.
There was a problem hiding this comment.
Have you fetched the getIterableValueType() so that you're comparing what's inside the array?
There was a problem hiding this comment.
The goal is to also handle cases like array_sum([1, 2, 3]) or array_sum($mixed).
| | ||
| public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type | ||
| { | ||
| $argType = $scope->getType($functionCall->args[0]->value); |
There was a problem hiding this comment.
Analysing array_sum() call will crash on this line.
There was a problem hiding this comment.
But tests are passing... how come?
There was a problem hiding this comment.
Because you're not testing calling array_sum() without any arguments.
ondrejmirtes force-pushed the master branch 2 times, most recently from f54fd5f to eca550a Compare 
| Feel free to reopen if you ever decide to finish this PR, thanks. |
2 participants
This PR:
ArraySumFunctionDynamicReturnTypeExtension$parameterswould work fine as well.Fix phpstan/phpstan#3964