Do not assume that arrays are always instanceof ArrayType #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
they might be intersection type. I don't think there's a way to test this without #315.
Member
| There's no actual difference because you can't write any union or intersection type of arrays as native closure return type... But otherwise yeah, I changed most instances of |
Contributor Author
| @ondrejmirtes I noticed it in a CI failure on #315 so I thought it made sense to change it. For future proofing. |
Member
| Which CI failure do you think is related to that? |
Contributor Author
Contributor Author
| Image for posterity since the link seems to be flaky: |
ondrejmirtes force-pushed the master branch 2 times, most recently from f54fd5f to eca550a Compare ondrejmirtes force-pushed the master branch 3 times, most recently from d45166a to 3526237 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
they might be intersection type, union type, or something else.
I don't think there's a way to test this without #315.