Skip to content

Fix array_filter with non-empty result #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix array_filter with non-empty result #315

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1f038e
Fix array_filter with non-empty result
enumag Sep 2, 2020
f26514d
Improve ConstantArrayType::generalize()
enumag Sep 3, 2020
6f2f8aa
Fix tests
enumag Sep 4, 2020
a5382f9
Fix ArrayFilterFunctionReturnTypeReturnTypeExtension
enumag Sep 4, 2020
0fe358f
Refactor
enumag Sep 4, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@enumag
enumag committed Sep 4, 2020
commit 6f2f8aaf1aff4f8e91e5702087dd56f91e0c0a71
4 changes: 2 additions & 2 deletions tests/PHPStan/Analyser/NodeScopeResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3189,7 +3189,7 @@ public function dataBinaryOperations(): array
'$coalesceArray',
],
[
'array<int, 1|2|3>',
'array<int, 1|2|3>&nonEmpty',
'$arrayToBeUnset',
],
[
Expand Down Expand Up @@ -9070,7 +9070,7 @@ public function dataIsset(): array
'$anotherArrayCopy',
],
[
'array<string, 1|2|3|4|null>',
'array<string, 1|2|3|4|null>&nonEmpty',
'$yetAnotherArrayCopy',
],
[
Expand Down
2 changes: 1 addition & 1 deletion tests/PHPStan/Analyser/data/generics.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function testD($int, $float, $intFloat)
assertType('DateTime|int', d($int, new \DateTime()));
assertType('DateTime|float|int', d($intFloat, new \DateTime()));
assertType('array()|DateTime', d([], new \DateTime()));
assertType('array<string, \'barrrr\'>|DateTime', d(['blabla' => 'barrrr'], new \DateTime()));
assertType('(array<string, \'barrrr\'>&nonEmpty)|DateTime', d(['blabla' => 'barrrr'], new \DateTime()));
}

/**
Expand Down