Skip to content

Added Feature Teamcity ErrorFormatter #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Added Feature Teamcity ErrorFormatter #294

wants to merge 7 commits into from

Conversation

MaximilianKresse
Copy link
Contributor

See #3701
ondrejmirtes
ondrejmirtes requested changes Aug 5, 2020
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix other potential build failures. Otherwise I like it! 👍 Thank you.
ondrejmirtes
ondrejmirtes requested changes Aug 5, 2020
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please rebase instead of introducing merge commits.
  2. The build is still red - Coding Standards.
@ondrejmirtes
Copy link
Member

The merge commit is still there. Feel free to squash all the changes into a single commit and rebase it on top of master, thanks.
@MaximilianKresse
Copy link
Contributor Author

I'm sorry. I don't know how to revert my already done merge... Because of this I created a new pr #295
@MaximilianKresse MaximilianKresse deleted the feature/teamcity-output-format branch August 5, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@MaximilianKresse @ondrejmirtes