Skip to content

Allow JSON_THROW_ON_ERROR in any bitwise-or-expression #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2019
Merged

Allow JSON_THROW_ON_ERROR in any bitwise-or-expression #27

merged 2 commits into from
Nov 28, 2019

Conversation

ahilke
Copy link
Contributor

@ahilke ahilke commented Nov 28, 2019

This adjusts the return type of json_decode/json_encode for arbitrary bitwise-or-expressions containing JSON_THROW_ON_ERROR.
Not sure if this is the best approach, but I do think there is a valid use case for this.
For example, passing through other options and adding JSON_THROW_ON_ERROR like this:

function encode(string $input, int $options): string { return json_encode($input, JSON_THROW_ON_ERROR | $options); }

Playground
@ahilke
Adds Failing Test.
5bfc034 
Problem: JSON_THROW_ON_ERROR option is not correctly detected when combined with an arbitrary integer. A use case for this could look like this: <?php function encodeWithOptions(string $input, int $options): string {	return json_encode($input, JSON_THROW_ON_ERROR | $options); } ?>
@ahilke ahilke force-pushed the allow-json-throw-on-error-with-any-int branch from 49b0409 to 017f728 Compare November 28, 2019 01:12
@ahilke
Allow Arbitrary Bitwise Or for JSON_THROW_ON_ERROR check.
b9e6878 
If the options argument is a (nested) bitwise or expression containing JSON_THROW_ON_ERROR, constrict the return type as expected.
@ahilke ahilke force-pushed the allow-json-throw-on-error-with-any-int branch from 017f728 to b9e6878 Compare November 28, 2019 01:19
@ondrejmirtes ondrejmirtes merged commit ecce7b7 into phpstan:master Nov 28, 2019
@ondrejmirtes
Copy link
Member

Awesome, thanks!
@ahilke ahilke deleted the allow-json-throw-on-error-with-any-int branch November 28, 2019 09:22
@darenas31415 darenas31415 mentioned this pull request Dec 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ahilke @ondrejmirtes