Skip to content

feat: improve Map::get() @throws inference #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

feat: improve Map::get() @throws inference #2297

merged 1 commit into from
Mar 21, 2023

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Mar 21, 2023

Opening based on phpstan/phpstan#9066, hope it's correct place where to put the extension
ondrejmirtes
ondrejmirtes requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a test that fails without the extension (and also test the code that is supposed to throw the exception).
simPod
simPod commented Mar 21, 2023
View reviewed changes
ondrejmirtes
ondrejmirtes reviewed Mar 21, 2023
View reviewed changes
ondrejmirtes
ondrejmirtes requested changes Mar 21, 2023
View reviewed changes
@ondrejmirtes ondrejmirtes merged commit 1ca8d1f into phpstan:1.10.x Mar 21, 2023
@ondrejmirtes
Copy link
Member

Thank you!
@simPod simPod deleted the throw branch March 21, 2023 11:50
@ondrejmirtes ondrejmirtes mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@simPod @ondrejmirtes