Allow symfony 5 #20
Closed
Allow symfony 5 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This isn’t neccesary. PHPStan 0.12 in phpstan/phpstan package won’t have the dependency on Symfony. If it’s a blocker for you right now, install the current stable version of phpstan/phpstan-shim. |
| @ondrejmirtes thanks for the quick response, Have you scheduled a date for the version? |
| Yes, December 3rd. |
Closed
| @ondrejmirtes 0.11.19 release of |
| @ondrejmirtes I'm sorry if I'm missunderstanding something, but how do I use rule packs (like strict rules or phpunit rules) with the shim package, since they all depend on |
| You use them exactly the same way, try it ;) On Mon, 25 Nov 2019 at 16:17, Edi Modrić ***@***.***> wrote: @ondrejmirtes <https://github.com/ondrejmirtes> I'm sorry if I'm missunderstanding something, but how do I use rule packs (like strict rules or phpunit rules) with the shim package, since they all depend on phpstan/phpstan? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20?email_source=notifications&email_token=AAAZTOHEBTGIMPAX2TQU6NTQVPT7HA5CNFSM4JQAPFV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCXPRQ#issuecomment-558200774>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZTOD4N7LDKR3LKOZY3FLQVPT7HANCNFSM4JQAPFVQ> . -- Ondřej Mirtes |
| Oh, the shim package replaces |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.