Template type variance rules #19
Conversation
arnaud-lb force-pushed the variance-rules branch 3 times, most recently from d29845f to d0f31f7 Compare 
There was a problem hiding this comment.
There isn't a test for this message.
There was a problem hiding this comment.
Inconsistence in/of:
in extended type %%s in class %s. vs.
in implemented type %%s of class %s. There was a problem hiding this comment.
Also there's no test for this message.
There was a problem hiding this comment.
This rule is missing a unit test: FunctionSignatureVarianceRuleTest
There was a problem hiding this comment.
There's not unit test for this rule: MethodSignatureVarianceRuleTest
src/Rules/Generics/VarianceCheck.php Outdated
src/Type/Type.php Outdated
There was a problem hiding this comment.
Can you explain what this method does? Also, is there any advantage in iterable over array? Other methods use arrays mainly...
There was a problem hiding this comment.
I found yield very handy in this case, as I didn't had to array_merge everything. I'm rewriting to use arrays instead, for consistency.
There was a problem hiding this comment.
Also changed the name and added some doc
arnaud-lb force-pushed the variance-rules branch from d0f31f7 to 8e3bdd6 Compare 
2 participants
This adds rules to check passing variant template types in incompatible positions. Specifically, this is checked in parameter types, return types, and @extends/@implements types.
A template-covariant template type can only be used in a covariant position: As return type, or where a template type parameter is covariant itself, with some twists.