Skip to content

Declare Connection::fetch methods as impure #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from
Open

Declare Connection::fetch methods as impure #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions stubs/DBAL/Connection.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,100 @@ class Connection
*/
public function transactional(Closure $func);

/**
* @param list<mixed>|array<string, mixed> $params
* @param array<int, int|string|Type|null>|array<string, int|string|Type|null> $types
*
* @return array<string, mixed>|false
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchAssociative(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param array<int, int|string|Type|null>|array<string, int|string|Type|null> $types
*
* @return list<mixed>|false
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchNumeric(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param array<int, int|string|Type|null>|array<string, int|string|Type|null> $types
*
* @return mixed
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchOne(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param array<int, int|string|Type|null>|array<string, int|string|Type|null> $types
*
* @return list<list<mixed>>
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchAllNumeric(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param array<int, int|string|Type|null>|array<string, int|string|Type|null> $types
*
* @return list<array<string,mixed>>
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchAllAssociative(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param array<int, int|string|Type|null>|array<string, int|string|Type|null> $types
*
* @return array<mixed,mixed>
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchAllKeyValue(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param array<int, int|string|Type|null>|array<string, int|string|Type|null> $types
*
* @return array<mixed,array<string,mixed>>
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchAllAssociativeIndexed(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param array<int, int|string|Type|null>|array<string, int|string|Type|null> $types
*
* @return list<mixed>
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchFirstColumn(string $query, array $params = [], array $types = []);

}
96 changes: 96 additions & 0 deletions stubs/DBAL/Connection4.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,100 @@ class Connection
*/
public function transactional(Closure $func);

/**
* @param list<mixed>|array<string, mixed> $params
* @param WrapperParameterTypeArray $types
*
* @return array<string, mixed>|false
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchAssociative(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param WrapperParameterTypeArray $types
*
* @return list<mixed>|false
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchNumeric(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param WrapperParameterTypeArray $types
*
* @return mixed
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchOne(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param WrapperParameterTypeArray $types
*
* @return list<list<mixed>>
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchAllNumeric(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param WrapperParameterTypeArray $types
*
* @return list<array<string,mixed>>
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchAllAssociative(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param WrapperParameterTypeArray $types
*
* @return array<mixed,mixed>
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchAllKeyValue(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param WrapperParameterTypeArray $types
*
* @return array<mixed,array<string,mixed>>
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchAllAssociativeIndexed(string $query, array $params = [], array $types = []);

/**
* @param list<mixed>|array<string, mixed> $params
* @param WrapperParameterTypeArray $types
*
* @return list<mixed>
*
* @throws Exception
*
* @phpstan-impure
*/
public function fetchFirstColumn(string $query, array $params = [], array $types = []);

}
Loading