Implement offset access type syntax #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ondrejmirtes requested changes Apr 29, 2022
rvanvelzen commented Apr 29, 2022
| ]), | ||
| ]; | ||
| | ||
| yield [ |
There was a problem hiding this comment.
Tests for A [B] already exist - just a few lines above
| @JanTvrdik what's the reason for the "confused" reaction? Do you disagree with the idea in general, with the implementation, or something else? |
| The context: phpstan/phpstan#7094 |
ondrejmirtes requested changes May 3, 2022
| /** @var TypeNode */ | ||
| public $offset; | ||
| | ||
| public function __construct(TypeNode $type, TypeNode $offset) |
There was a problem hiding this comment.
Does it make sense to allow any TypeNode here? Shouldn't it be narrowed down to just IdentifierTypeNode?
There was a problem hiding this comment.
While it might make no sense in practice, array{foo: string}['foo'] could resolve to string.
There was a problem hiding this comment.
Alright, make sure to add a test case for this in phpstan-src when you work on it :) Thanks :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This implements offset access types keeping as much BC as possible. Notably, whitespace between the type and
[is not allowed (soA[B]is valid butA [B]parses as justA, as before)