Fixed type hints for connection methods #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Updated type hints for acquire, drop, and release methods
| I haven't signed the OCA so I don't think you can actually merge this. However, the maintainers of this project are free to use my code as inspiration for their own patch! |
| FYI, the patch here will introduce a circular import issue. Putting the class names in quotes fixes that. |
| @troyswanson Is there anything I can do to enable you to sign the OCA? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updated type hints for
acquire,drop, andreleasemethods in ConnectionPool classThis fixes #52