Add Vagrant (VirtualBox provider) #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Vanhaesendonck <philippe.vanhaesendonck@oracle.com>
- No more default password to avoid images with know passwords - Root password locked by default - Keep firewalld installed Signed-off-by: Philippe Vanhaesendonck <philippe.vanhaesendonck@oracle.com>
Signed-off-by: Philippe Vanhaesendonck <philippe.vanhaesendonck@oracle.com>
Signed-off-by: Philippe Vanhaesendonck <philippe.vanhaesendonck@oracle.com>
Signed-off-by: Philippe Vanhaesendonck <philippe.vanhaesendonck@oracle.com>
Signed-off-by: Philippe Vanhaesendonck <philippe.vanhaesendonck@oracle.com>
Djelibeybi reviewed Mar 12, 2020
| net-tools | ||
| iptables-services | ||
| btrfs-progs | ||
| bind-utils |
There was a problem hiding this comment.
Why are you removing bind-utils, out of curiousity?
There was a problem hiding this comment.
It isn't currently installed on any box an nobody complained so far ;)
There was a problem hiding this comment.
Yeah, but you specifically make a choice here to remove it. What was the rationale behind removing the line?
There was a problem hiding this comment.
For now, building the the exact same boxes we are releasing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add support for Vagrant boxes