8369560: Slowdebug build without CDS fails

[MBaesken]

Slowdebug builds without CDS fail, this was noticed on AIX.
On Linux x86_64 (when using --with-debug-level=slowdebug --disable-cds ) I get a little better error messages , pointing already to code locations :

/jdk/src/hotspot/share/oops/trainingData.hpp:155: error: undefined reference to 'TrainingData::TrainingDataLocker::_snapshot' /jdk/src/hotspot/share/classfile/vmClasses.cpp:123: error: undefined reference to 'AOTLinkedClassBulkLoader::preload_classes(JavaThread*)' collect2: error: ld returned 1 exit status 

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8369560: Slowdebug build without CDS fails (Bug - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer) Review applies to 13b3a872

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27744/head:pull/27744
$ git checkout pull/27744

Update a local copy of the PR:
$ git checkout pull/27744
$ git pull https://git.openjdk.org/jdk.git pull/27744/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27744

View PR using the GUI difftool:
$ git pr show -t 27744

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27744.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369560: Slowdebug build without CDS fails Reviewed-by: mdoerr, kvn 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 4728f74: 8369571: Parallel: Use ThreadsClaimTokenScope in PSAdjustTask
• 1605e83: 8369574: Remove javax/management/remote/mandatory/connection/BrokenConnectionTest.java from ProblemList-Virtual.txt
• a6f624b: 8369468: Rdtsc: Move getCPUIDBrandString_stub into VM_Version stub area
• ... and 6 more: https://git.openjdk.org/jdk/compare/5594d6bc88bbe39e6ebfd02fb9c37cf40b8d0479...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[TheRealMDoerr]

Thanks for fixing it! Alternatively, you could use the CDS_ONLY macro for single statements. Would make it a bit shorter. But, I'm ok with either version.

[mlbridge]

Webrevs

• 01: Full - Incremental (8d69ea9c)
• 00: Full (13b3a872)

[MBaesken]

Thanks for the review !
With this change Linux slowdebug without CDS builds again ; AIX slowdebug does not have the link error any more, but faces a TOC issue. But this is something to be addressed elsewhere.

[vnkozlov]

Good.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 0af959a.
Since your change was applied there have been 10 commits pushed to the master branch:

• 98e1d2f: 8369563: Gtest dll_address_to_function_and_library_name has issues with stripped pdb files
• 4728f74: 8369571: Parallel: Use ThreadsClaimTokenScope in PSAdjustTask
• 1605e83: 8369574: Remove javax/management/remote/mandatory/connection/BrokenConnectionTest.java from ProblemList-Virtual.txt
• ... and 7 more: https://git.openjdk.org/jdk/compare/5594d6bc88bbe39e6ebfd02fb9c37cf40b8d0479...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 0af959a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[JoKern65]

Could you please add the line again, so that trainingsData.cpp remains unchanged by this PR?