Use storage scope for annotations's text part and improve annotation regex. #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #43 +/- ## ========================================== + Coverage 69.23% 69.97% +0.74% ========================================== Files 13 13 Lines 481 493 +12 ========================================== + Hits 333 345 +12 Misses 148 148
Continue to review full report at Codecov.
|
nishtahir reviewed Feb 15, 2021
dist/Kotlin.JSON-tmLanguage Outdated
| "match": "@[a-zA-Z_]\\w*", | ||
| "name": "meta.annotation.kotlin" | ||
| "match": "@(?:(?:file|property|field|get|set|receiver|param|setparam|delegate)\\s*:\\s*)?[a-zA-Z_]\\w*", | ||
| "name": "storage.type.annotation.kotlin" |
Owner
There was a problem hiding this comment.
I've left a comment for discussion here #42 (comment). That would need to be addressed before this gets merged
Contributor Author
| Oops closed by mistake, did not knew master is up on a PR. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #42 by merging use-site annotation regex with one without use-site.
Also moves the scope of the
meta.annotation.kotlintostorage.type.annotation.kotlinfor the name of the annotation (excluding the braces).