Skip to content

Another failure in FileMock #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JanTvrdik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Another failure in FileMock #304

JanTvrdik wants to merge 1 commit into from

Conversation

@JanTvrdik
Copy link
Contributor

@JanTvrdik JanTvrdik commented Mar 22, 2016

No description provided.

@JanTvrdik
Copy link
Contributor Author

JanTvrdik commented Mar 22, 2016

Isolated to https://3v4l.org/gTXsR, seems like a PHP bug.
@milo milo force-pushed the master branch 2 times, most recently from 20198c1 to 1b583e9 Compare May 19, 2016 09:41
@dg dg force-pushed the master branch 2 times, most recently from 715ed4e to 334dc33 Compare January 4, 2017 14:23
@dg dg force-pushed the master branch 3 times, most recently from c7e8a12 to df5e87f Compare July 24, 2017 14:21
@dg dg force-pushed the master branch 2 times, most recently from b9711f5 to 3f273cf Compare June 7, 2018 11:24
@milo
Copy link
Member

milo commented Oct 10, 2018

@JanTvrdik I thought it has been solved but it's still failing on 3v4al.org. Did you report PHP bug? I can't find any open or solved.
@JanTvrdik
Copy link
Contributor Author

JanTvrdik commented Oct 10, 2018

@milo I don't remember opening any bug so it's possible that it has never been reported.
@JanTvrdik
Copy link
Contributor Author

JanTvrdik commented Oct 10, 2018

Just found in PHP documentation

If you have opened the file in append (a or a+) mode, any data you write to the file will always be appended, regardless of the file position, and the result of calling fseek() will be undefined.
@milo
Copy link
Member

milo commented Oct 10, 2018

But in doc of fopen()

a - Open for writing only; place the file pointer at the end of the file. If the file does not exist, attempt to create it. In this mode, fseek() has no effect, writes are always appended.
a+ - Open for reading and writing; place the file pointer at the end of the file. If the file does not exist, attempt to create it. In this mode, fseek() only affects the reading position, writes are always appended.

The a+ mode is about read/append. How would one can read.

I'll open PHP bug/doc issue.
@milo
Copy link
Member

milo commented Oct 10, 2018

Will see https://bugs.php.net/bug.php?id=76995
@milo
Copy link
Member

milo commented Oct 11, 2018

As I expected, it is a problem of lower layer. So, documentation issue.

Is a good idea to emit notice by FileMock::stream_seek() in a+ mode? IMHO yes, it may notice programmer about this clumsy behaviour.
@milo milo force-pushed the master branch 2 times, most recently from eaaeb7b to 7184606 Compare February 21, 2019 06:47
@dg dg force-pushed the master branch 2 times, most recently from ee525b7 to 6ca248e Compare February 27, 2019 13:34
@dg dg force-pushed the master branch 2 times, most recently from 55e4447 to ad2df9a Compare November 19, 2019 01:08
@dg dg force-pushed the master branch 6 times, most recently from 3267365 to 9d28a53 Compare February 6, 2023 15:42
@dg dg force-pushed the master branch 3 times, most recently from dddb52b to 78555c7 Compare March 2, 2023 02:15
@dg dg force-pushed the master branch 3 times, most recently from 95674fc to c5eff68 Compare December 5, 2023 17:32
@dg dg force-pushed the master branch 6 times, most recently from cc8395d to 8b22550 Compare June 18, 2024 20:27
@dg dg force-pushed the master branch 2 times, most recently from 2fee261 to c118637 Compare October 23, 2024 23:57
@dg dg force-pushed the master branch 2 times, most recently from e141379 to 4b8a851 Compare June 19, 2025 17:58
@dg dg force-pushed the master branch 4 times, most recently from 8d2c31b to f7328f7 Compare August 7, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@JanTvrdik @milo