fix: fix and test dynamic import() (#350)

Author: ehmicky

src/node_dependencies/index.js

@@ -69,9 +69,11 @@ const getFileDependencies = async function ({ path, packageJson, pluginsModulesP
  // but should use `fs.readFile()` instead
  const dependencies = precinct.paperwork(path, { includeCore: false })
  const depsPaths = await Promise.all(
- dependencies.map((dependency) =>
- getImportDependencies({ dependency, basedir, packageJson, state, treeShakeNext, pluginsModulesPath }),
- ),
+ dependencies
+ .filter(Boolean)
+ .map((dependency) =>
+ getImportDependencies({ dependency, basedir, packageJson, state, treeShakeNext, pluginsModulesPath }),
+ ),
  )
  // TODO: switch to Array.flat() once we drop support for Node.js < 11.0.0
  // eslint-disable-next-line unicorn/prefer-spread

tests/fixtures/dynamic-import/.eslintrc

@@ -0,0 +1,6 @@
+{
+ "parserOptions": { "sourceType": "module" },
+ "rules": {
+ "node/no-unsupported-features/es-syntax": 0
+ }
+}

tests/fixtures/dynamic-import/function.js

@@ -0,0 +1,4 @@
+export const handler = async function () {
+ const variable = 'test'
+ await import(variable)
+}

tests/main.js

@@ -181,6 +181,14 @@ testBundlers('Ignore invalid require()', [ESBUILD, ESBUILD_ZISI, DEFAULT], async
  await zipNode(t, 'invalid-require', { opts: { jsBundler: bundler } })
 })
 
+testBundlers('Can use dynamic import() with esbuild', [ESBUILD, ESBUILD_ZISI], async (bundler, t) => {
+ await zipNode(t, 'dynamic-import', { opts: { jsBundler: bundler } })
+})
+
+testBundlers('Bundling does not crash with dynamic import() with zisi', [DEFAULT], async (bundler, t) => {
+ await t.throwsAsync(zipNode(t, 'dynamic-import', { opts: { jsBundler: bundler } }), /export/)
+})
+
 testBundlers('Can require local files', [ESBUILD, ESBUILD_ZISI, DEFAULT], async (bundler, t) => {
  await zipNode(t, 'local-require', { opts: { jsBundler: bundler } })
 })