This repository was archived by the owner on May 22, 2024. It is now read-only.
fix: fix and test dynamic import() #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
erezrokah approved these changes Mar 1, 2021
eduardoboucas approved these changes Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using an
import()with a variable argument (as opposed to a string),precintreturns[undefined]instead of[]. This leads the following function to fail:zip-it-and-ship-it/src/node_dependencies/index.js
Lines 104 to 106 in a437e74
This PR filters out
undefined. This ensures bundling works.This only applies to the ZISI bundler.
esbuildhandles this case correctly.This also adds tests for both ZISI and
esbuildbundlers.