Skip to content

feat: add framework to deploy properties #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2021
Merged

feat: add framework to deploy properties #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67aadd1
feat: add framework to deploy
vbrown608 Mar 15, 2021
e71d1cb
feat: accept framework with deploy update
vbrown608 Mar 15, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions go/models/deploy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions go/models/deploy_files.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions go/porcelain/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ type DeployOptions struct {
Title string
Branch string
CommitRef string
Framework string
UploadTimeout time.Duration
PreProcessTimeout time.Duration

Expand Down Expand Up @@ -220,9 +221,10 @@ func (n *Netlify) DoDeploy(ctx context.Context, options *DeployOptions, deploy *
options.functions = functions

deployFiles := &models.DeployFiles{
Files: options.files.Sums,
Draft: options.IsDraft,
Async: n.overCommitted(options.files),
Files: options.files.Sums,
Draft: options.IsDraft,
Async: n.overCommitted(options.files),
Framework: options.Framework,
}
if options.functions != nil {
deployFiles.Functions = options.functions.Sums
Expand Down
4 changes: 4 additions & 0 deletions swagger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2358,6 +2358,8 @@ definitions:
properties:
large_media_enabled:
type: boolean
framework:
type: string
deployFiles:
type: object
properties:
Expand All @@ -2371,6 +2373,8 @@ definitions:
type: object
branch:
type: string
framework:
type: string
buildStatus:
type: object
properties:
Expand Down