Skip to content

chore!: use pure ES modules with git-utils #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2021
Merged

chore!: use pure ES modules with git-utils #3943

merged 2 commits into from
Dec 15, 2021

Conversation

@ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Dec 14, 2021

Part of #3742

This switches git-utils from CommonJS to pure ES modules.

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅
@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Dec 14, 2021
@ehmicky ehmicky self-assigned this Dec 14, 2021
ehmicky
ehmicky commented Dec 14, 2021
View reviewed changes
packages/git-utils/tests/main.mjs
@@ -1,10 +1,8 @@
'use strict'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file must be .mjs due to ava not working well in monorepos mixing CommonJS and ESM packages. Once all packages of this monorepos are switched to ESM, this file can be renamed to .js and this comment can be removed.
ehmicky
ehmicky commented Dec 14, 2021
View reviewed changes
packages/git-utils/tests/main.mjs

test('Should define all its methods and properties', (t) => {
const git = getGitUtils(DEFAULT_OPTS)
// eslint-disable-next-line fp/no-mutating-methods
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See netlify/eslint-config-node#376
@ehmicky ehmicky force-pushed the chore/git-utils-esm branch 2 times, most recently from 307f157 to d7ad013 Compare December 15, 2021 15:25
@ehmicky ehmicky force-pushed the chore/git-utils-esm branch from d7ad013 to 7237b00 Compare December 15, 2021 17:13
@kodiakhq kodiakhq bot merged commit 59a9189 into main Dec 15, 2021
@kodiakhq kodiakhq bot deleted the chore/git-utils-esm branch December 15, 2021 18:58
@token-generator-app token-generator-app bot mentioned this pull request Dec 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge type: chore work needed to keep the product and development running smoothly

3 participants

@ehmicky @erezrokah