Sanitize "." in sanitizedPaths #403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Problem: If the title of an entry contains a ".", the path becomes invalid. Solution: Removing all "."s in the path using slugify resolves this problem. Furthermore the following changes got made to simplify the code of sanitizePath: - Slugify automatically removes leading, trailing or doubled replacement chars, so doing it explicitly is just a no-op. - Also slugify has an option for converting to lower case.
Signed-off-by: Raphael Höser <raphael@hoeser.info>
Signed-off-by: Raphael Höser <raphael@hoeser.info>
…efault char set Change the bahavior to replace dots instead of removing them Signed-off-by: Raphael Höser <raphael@hoeser.info>
Snapstromegon changed the title My solution was using replaceAll, but that isn't supported in node 12. Therefore I switched to regex for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Problem:
If the title of an entry contains a ".", the path becomes invalid.
Solution:
Replacing all "."s in the path using slugify resolves this problem.
Furthermore the following changes got made to simplify the code of sanitizePath: