fix: implement retry strategy and rate limiting for CSS referential scraper to handle 429 responses #157
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Problem
The CSS referential scraper was failing with 429 "Too Many Requests" HTTP responses when fetching data from W3C and MDN APIs:
This occurred because the scraper was making consecutive HTTP requests without any rate limiting or retry logic, causing APIs to reject requests when rate limits were exceeded.
Solution
This PR implements a comprehensive HTTP retry strategy with rate limiting to make the CSS referential scraper more resilient:
Rate Limiting
Retry Strategy with Exponential Backoff
Implementation Details
The
CachedHttpDownloader
class now includes:Testing
Added comprehensive unit tests that verify:
Benefits
The CSS referential scraper should now run successfully even when encountering occasional rate limiting or temporary network issues from external APIs.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
httpbin.org
php demo/test-retry-logic.php
(dns block)https://api.github.com/repos/Masterminds/html5-php/zipball/fcf91eb64359852f00d921887b219479b4f21251
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/bovigo/vfsStream/zipball/fe695ec993e0a55c3abdda10a9364eb31c6f1bf0
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/guzzle/guzzle/zipball/b51ac707cfa420b7bfd4e4d5e510ba8008e822b4
/usr/bin/php8.3 -n -c /tmp/q2nynb /usr/bin/composer install --ignore-platform-req=ext-pcov
(http block)/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/guzzle/promises/zipball/481557b130ef3790cf82b713667b43030dc9c957
/usr/bin/php8.3 -n -c /tmp/q2nynb /usr/bin/composer install --ignore-platform-req=ext-pcov
(http block)/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/guzzle/psr7/zipball/21dc724a0583619cd1652f673303492272778051
/usr/bin/php8.3 -n -c /tmp/q2nynb /usr/bin/composer install --ignore-platform-req=ext-pcov
(http block)/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/krakjoe/pcov-clobber/zipball/4c30759e912e6e5d5bf833fb3d77b5bd51709f05
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/nikic/PHP-Parser/zipball/715f4d25e225bc47b293a8b997fe6ce99bf987d2
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/php-fig/http-client/zipball/bb5906edc1c324c9a05aa0873d40117941e5fa90
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/php-fig/http-factory/zipball/2b4765fddfe3b508ac62f829e852b1501d3f6e8a
/usr/bin/php8.3 -n -c /tmp/q2nynb /usr/bin/composer install --ignore-platform-req=ext-pcov
(http block)/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/php-fig/http-message/zipball/402d35bcb92c70c026d1a6a9883f06b2ead23d71
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/ralouphie/getallheaders/zipball/120b605dfeb996808c31b6477290a714d356e822
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/sebastianbergmann/diff/zipball/ba01945089c3a293b01ba9badc29ad55b106b0bc
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/5c9eeac41b290a3712d88851518825ad78f45c71
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/b4f479ebdbf63ac605d183ece17d8d7fe49c15c7
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/539c6691e0623af6dc6f9c20384c120f963465a0
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/sebastianbergmann/resource-operations/zipball/05d5692a7993ecccd56a03e40cd7e5b09b1d404e
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/sebastianbergmann/type/zipball/75e2c2a32f5e0b3aef905b9ed0b179b953b3d7c7
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/sebastianbergmann/version/zipball/c6c1022351a901512170118436c764e473f6de8c
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/symfony/console/zipball/492de6dfd93910d7d7a729c5a04ddcd2b9e99c4f
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/symfony/css-selector/zipball/9b784413143701aa3c94ac1869a159a9e53e8761
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
/usr/bin/php8.3 -n -c /tmp/q2nynb /usr/bin/composer install --ignore-platform-req=ext-pcov
(http block)/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/symfony/dom-crawler/zipball/976302990f9f2a6d4c07206836dd4ca77cae9524
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/symfony/polyfill-ctype/zipball/a3cc8b044a6ea513310cbd48ef7333b384945638
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)https://api.github.com/repos/symfony/string/zipball/f96476035142921000338bad71e5247fbc138872
/usr/bin/php8.3 -n -c /tmp/0FspY8 /usr/bin/composer install --ignore-platform-req=ext-pcov --no-interaction
(http block)www.w3.org
php scripts/css-referential-scraper --force-refresh
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.