enable csv response format #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @mvexel Would you have time for a review? I have two smaller projects in the pipeline I can't reasonably open source without this change being merged and released. Thanks a lot! |
Contributor Author
| I'm no longer sure why I need the CSV output anyway. It would be possible to parse the JSON and transform to CSV in the code. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implicitly the CSV response format would already work by specifying e.g.
responseformat='csv("addr:street", "addr:place", "addr:housenumber";true;";")'. But instead of trying to parse JSON the raw response should be returned.Failed checks are timeout errors.