Handle server runtime error from overpass API #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Do you always receive an empty response or only sometimes? Which Python version are you using? When I execute the request (2.7 and 3.4) I receive a TimeoutError after a while. |
Contributor Author
| I set the timeout parameter quite high (600), using Python 2.7.6 (Ubuntu trusty) I haven't tried all that many times, but it happened tree or four times in a row, then I started investigating and was able to make this fix (using a couple more requests), so approx 5-6 times in a row at least. Strange if you are not able to reproduce it. |
Collaborator
| The timeout value was the key, with 600 I receive an empty response. Thank you for the pull request! |
tbolender added a commit that referenced this pull request Nov 11, 2015
Handle server runtime error from overpass API
Contributor Author
| Great, thanks for a great library! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I used this project to send the following query:
But after a while I got an empty response. After digging a bit more I found that the overpass API returned a response akin to the one described here: drolbr/Overpass-API#104
Strangely enough the response had a 200 OK status code, so this lib continued to return the empty elements array, leaving me none the wiser.
This PR tries to remedy this, by raising a ServerRuntimeError exception when this happens.