Supporting big files #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cbatis suggested changes Jul 1, 2021
cbatis previously approved these changes Jul 2, 2021
cbatis suggested changes Jul 16, 2021
src/job-client.js Outdated
| } | ||
| | ||
| /** | ||
| * Call the Modzy API Service that return the jobs features |
Contributor
There was a problem hiding this comment.
Call Modzy's API Service to return job features
Contributor Author
There was a problem hiding this comment.
Done, thanks Caro
src/job-client.js Outdated
| | ||
| /** | ||
| * Call the Modzy API Service that return the jobs features | ||
| * @return {Object} a updated job instance |
cbatis approved these changes Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
With this PR I'm isolating embedded input from file input, so the file handling submit the inputs by using the open and close jobs logic, avoiding server errors to happen.
I also move some methods from
ModzyClienttoJobClient, so we gain some consistency with other SDK's, also keep the signature so we do not break anything.Related issues
There is not an issue reported but is a well-known fact that is a problem if you want to submit a big list of local files.
Tests
I add a sample to use this type of input.
Checklist