System sensors #834
Open
System sensors #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I can change all themes updating FAN_SPEED to FAN_PERCENT, but before doing this work I want to be sure this request is going to be merged |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What the PR is about:
Current sensors doesn't include system sensors like motherboard temperature o fan. This PR tries to fix that by letting you see stats (like temp, or fans) for each system sensors in the themes.
What it does:
Getting the data: I've refactored the sensor code (sensors_python.py, sensors_librehardwaremonitor.py) so that it can grab stats from system fan and temperature. Also, changed sensors for fans distiguishing between fan speed (RPM) and fan percent..
New Theme functionality: Themes can now use a new format. I added a theme called 3.5inchThemeSystem as an example.
Keeping old themes working (Backwards Compatibility): Endeed, current cpu fan speed will change from default percentage to rpm speed as the current FAN_SPEED is now returning RPM speed for fans.
Totaly open to any change or refactoring proposal you can have.
Testing:
I've tested this on my setup: