Add figure tag #258
Merged
Add figure tag #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pascalwengerter suggested changes Oct 25, 2019
Contributor
pascalwengerter left a comment
pascalwengerter left a comment There was a problem hiding this comment.
Great work, @lumisce! Just two small things and we're good to merge :)
borref requested changes Oct 26, 2019
Collaborator
borref left a comment
borref left a comment There was a problem hiding this comment.
Just a tiny detail missing ;)
borref approved these changes Oct 26, 2019
pascalwengerter approved these changes Oct 27, 2019
Contributor
pascalwengerter left a comment
pascalwengerter left a comment There was a problem hiding this comment.
Looking good to me!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue #192: adds figure component
Changes