Introduce Core Component Generator #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This generator generates a matestack core component in app/concepts/matestack, a test file and a doc file.
pascalwengerter previously approved these changes Oct 19, 2019
Contributor
pascalwengerter left a comment
pascalwengerter left a comment There was a problem hiding this comment.
Great work, @marcoroth! I am not quite sure yet whether I'm fine with shipping a core component generator with the gem (mostly because users could be confused and there is probably a limited set of core components, after all), but let's see what @jonasjabari thinks about it ;)
Collaborator Author
| I agree. This generator only makes sense inside the matestack-ui-core codebase. Maybe we can limit this generator to only work/appear in here. |
jonasjabari requested changes Oct 23, 2019
Member
jonasjabari left a comment
jonasjabari left a comment There was a problem hiding this comment.
@marcoroth greate work! just one thing (as @pascalwengerter already considered) please move the documentation to the contribution docs in oder not to confuse normal matestack users :)
jonasjabari approved these changes Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Introduce Core Component Generator
This PR introduces the
matestack:core:componentgenerator. This generator makes it a lot easier to scaffold new core components and therefore speeds up the development of them.Example
The generator can be invoked with
rails generate matestack:core:component NAMEThis will generate the following files:
Changes
matestack:core:componentgeneratorNotes
This PR follows the same naming scheme for the generator names as #251.