Skip to content

Conversation

@pascalwengerter
Copy link
Contributor

Issue #146: Remove RecordTagHelper

Changes

  • Remove RecordTagHelper from component/dynamic.rb and app/app.rb
@jonasjabari
Copy link
Member

Actually, I would love to remove all Rails Helper Modules. The modules were included in order to enable the usage of these helpers when writing haml/erb templates for custom components. But I would prefer telling the matestack user to include the desired module to her/his component individually rather than having them unused in ALL components. Or creating a specific Rails-View core component with some documentation. what do you think @pascalwengerter ?

@pascalwengerter
Copy link
Contributor Author

If possible, I'm all in on removing those Rails Helpers (especially if they aren't used in most cases).

Preferred option would be either telling the user to include/require them, or create another kind of "custom base" component that users' custom components inherit from?

@jonasjabari
Copy link
Member

Yes, try to remove all ActionView modules and create a new static and dynamic core component which inherit from the original core components and include the ActionView modules. You may call it something like "StaticActionViewComponent/DynamicActionViewComponent" e.g.

@pascalwengerter
Copy link
Contributor Author

@jonasjabari I can do so in another PR. Could you merge this one to fix the immanent issue with Rails 6 (or, even more so, get this issue out of the way and see which others arise 💪 )

@jonasjabari jonasjabari merged commit 7ba28c1 into develop Oct 28, 2019
@pascalwengerter pascalwengerter deleted the remove_unused_helper branch October 28, 2019 11:25
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants